fix(window-state): The window size state needs to be related to the screen's scale_factor. #2505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was changed in #1743 deliberately for changing scale factors on the same resolution screen I feel like there's no right answer to this when the resolution and scaling are changing, we either break on resolution change or on scaling change 😥 I'm thinking maybe we should check for the monitor and see if we're still on the same monitor, and don't restore the size if that have changed, like what we did for the position |
|
Thank you for your answer. I just completed the migration from version 1.x to 2.x and found that the window size status was inconsistent with the 1.x version. I mistakenly thought that the code was not implemented.😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window size state needs to be related to the screen's
scale_factor. Otherwise, if the external monitor resolution is inconsistent, the restored window size will be scaled relative to the previous state.